Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

The premerge system will fail somewhat often due to issues unrelated to the patch being tested. This patch adds a link within the long form outputs to the issue tracker prompting users to open an issue if they see flakes/soemthing broken at HEAD/anything else wrong.

The premerge system will fail somewhat often due to issues unrelated to
the patch being tested. This patch adds a link within the long form
outputs to the issue tracker prompting users to open an issue if they
see flakes/soemthing broken at HEAD/anything else wrong.
@boomanaiden154 boomanaiden154 requested a review from cmtice May 20, 2025 23:56
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

If we find the quality of these issues is lacking, in future we could consider using GitHub's issue templates to provide a starting point like "Build URL: " and so on.

@boomanaiden154
Copy link
Contributor Author

If we find the quality of these issues is lacking, in future we could consider using GitHub's issue templates to provide a starting point like "Build URL: " and so on.

Yep, agreed.

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boomanaiden154 boomanaiden154 merged commit 4667209 into llvm:main May 22, 2025
11 checks passed
@boomanaiden154 boomanaiden154 deleted the generate-test-report-link-for-reporting-issues branch May 22, 2025 08:12
@DavidSpickett
Copy link
Collaborator

We don't need to fix this because Buildkite will be going away soon but FYI just in case anyone else reports it...

Buildkite does not render a blank line if this new text is placed directly after the </details> tag. Neither does Visual Studio Code's renderer, but Github does. Or maybe they all do but to varying heights, but on Buildkite it's hard to read as a result.

Buildkite:
Screenshot from 2025-05-29 17-27-52
Github:
Screenshot from 2025-05-29 17-29-33

Also I notice the emoji not working, looks like GitHub doesn't have these I'll try to confirm. If so, 🐧 and 🪟 could work :)

@DavidSpickett
Copy link
Collaborator

#142101 to fix the emoji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants